Add support for building and using Mac Catalyst offsets #52777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running a private build since this affects packaging https://dev.azure.com/dnceng/internal/_build/results?buildId=1141962&view=results |
steveisok
approved these changes
May 18, 2021
akoeplinger
approved these changes
May 18, 2021
| @@ -893,6 +893,9 @@ | |||
| /* The JIT/AOT targets tvOS */ | |||
| #cmakedefine TARGET_TVOS 1 | |||
|
|
|||
| /* The JIT/AOT targets Mac Catalyst */ | |||
| #cmakedefine TARGET_MACCAT 1 | |||
There was a problem hiding this comment.
nit: I think we should call this TARGET_MACCATALYST so it's consistent with how we're using it everywhere else (can be done in a follow-up PR).
There was a problem hiding this comment.
That came in with #51669, I'm innocent
| @@ -208,6 +208,7 @@ jobs: | |||
| - Browser_wasm | |||
| - tvOS_arm64 | |||
| - iOS_arm64 | |||
| - MacCatalyst_x64 | |||
There was a problem hiding this comment.
nit: if I understand this correctly this job builds the AOT offsets for all archs, not just iOS_arm64 or MacCatalyst_x64 right? we should add a comment to explain it since this is quite confusing.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.